picking video file: remove scoped storage api#221
Open
Funami580 wants to merge 1 commit intoabdallahmehiz:mainfrom
Open
picking video file: remove scoped storage api#221Funami580 wants to merge 1 commit intoabdallahmehiz:mainfrom
Funami580 wants to merge 1 commit intoabdallahmehiz:mainfrom
Conversation
Based on the reaction to #185 I say that is where the community wants it to go since the current file picker solution is not good. I think everybody wants, at the minimum, a file manager like Next Player or at most, a library like VLC. |
Owner
|
I am working on a Solution using the MediaStore APIs but progress has been pretty slow cause life, I'll keep this PR open for now, might inspire some code from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure, if this is the direction this project wants to go, but I thought I’d give it a try. I added the permission to manage the entire storage, like VLC does: https://github.com/videolan/vlc-android/blob/2e6e0bd6a6667af607824ffbd5f11b746026f8a9/application/vlc-android/AndroidManifest.xml#L13. The logic is based on https://stackoverflow.com/a/78813970. Now we can select a video file without granting permissions each time. The problem of granting permissions was also described in #28:
For now, this will probably take more clicks than before as one has to select the specific directory, but this can be alleviated in the future by adding options to open the last directory or bookmark directories.